-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bulk update of all dependencies #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Just one small thing I'm not sure about in the python sample app.
"aws-cdk.core==1.61.1", | ||
"aws-rfdk==0.17.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this....
Version 0.17.0 of RFDK uses CDK 1.57.0, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches the Typescript version of the example. Hrm... that's a pickle. I guess we'll have to leave the examples on the last release, and bump them (including CDK version) on release.
integ will have to be different. It's intended to be used with the tip-of-mainline.
Note: I had to remove building our example app from the |
There's some tangling between our dependencies that make them tricky for Dependabot to update on its own. This is a bulk update of all of our deps; mostly to address the security issue with
dot-prop
.The more notable updates are:
Tag.add
interface (see: feat(core): new APIs for Aspects and Tags aws-cdk#9558 ), and implementing a new property of theIResource
interface (see: feat: make imported resources account/region-aware aws-cdk#8280 ).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license